ringbuffer_trait: add extend_from_slice #134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
force-pushed
the
extend-from-slice
branch
from
825971b to
f6f09b2
Compare
phip1611
force-pushed
the
extend-from-slice
branch
from
f6f09b2 to
b2b2133
Compare
|
I rebased the PR. Are we good to go @NULLx76 ? |
phip1611
force-pushed
the
extend-from-slice
branch
2 times, most recently
from
f64f30b to
b2bc618
Compare
phip1611
force-pushed
the
extend-from-slice
branch
from
956c0e1 to
8d97841
Compare
This adds an extend_from_slice function to the RingBuffer trait. The default implementation calls push() for each element. However, by creating specialized implementations for the various buffers, one can do various performance optimizations in a follow-up.
phip1611
force-pushed
the
extend-from-slice
branch
from
8d97841 to
80d6a3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an extend_from_slice function to the RingBuffer trait. The default implementation calls push() for each element. However, by creating specialized implementations for the various buffers, one can do various performance optimizations in a follow-up.
Partially closes #124